Codecov Report

Patch coverage: 4.76% and project coverage change: -0.03 ⚠️

Comparison is base (150a184) 49.64% compared to head (812944b) 49.61%.

@@            Coverage Diff             @@
##           master   #13755      +/-   ##
==========================================
- Coverage   49.64%   49.61%   -0.03%     
==========================================
  Files         256      256              
  Lines       43914    43800     -114     
==========================================
- Hits        21800    21733      -67     
+ Misses      19958    19934      -24     
+ Partials     2156     2133      -23     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

I worry about this one because it's such a widely used feature. Could be perhaps just add a deprecation warning for a few versions before removing?

@todaywasawesome it's been deprecated since 2.5, and we've pushed removal twice. 😆 https://argo-cd.readthedocs.io/en/latest/operator-manual/upgrading/2.4-2.5/#argocd-cm-plugins-cmps-are-deprecated

You can always count on me to ask the critical questions 🥴

It's a fair point though. I fully expect people will be on this thread two years from now saying "aw man, why did y'all do this, I'm just upgrading from 1.9, this sucks." :-P

@crenshaw-dev could you please fix conflicts?

@pasha-codefresh this is ready for another look

@pasha-codefresh wanna glance at the e2e test fixes?

Thank you